JonasJ-ap commented on code in PR #5787:
URL: https://github.com/apache/iceberg/pull/5787#discussion_r979163966
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -975,4 +1008,19 @@ private <T extends SdkClientBuilder> void
configureEndpoint(T builder, String en
builder.endpointOverride(URI.create(endpoint));
}
}
+
+ @VisibleForTesting
+ <T extends ApacheHttpClient.Builder> void configureApacheHttpClientBuilder(T
builder) {
+ boolean setConnectionTimeout = apacheHttpClientConnectionTimeout != null;
+ boolean setSocketTimeout = apacheHttpClientSocketTimeout != null;
+ if (setConnectionTimeout && setSocketTimeout) {
+ builder
Review Comment:
Thank you for your review. However, I may not get what you mean. Do you
refer to line 1017? This method `configureApacheHttpClientBuilder` does not
have return value given its return type is `void`. The `builder` standing alone
in line 1017 is just due to the autoformatting. Indeed, I design this method so
that it can be used like:
```
ApacheHttpClient.builder().applyMutation(this::configureApacheHttpClientBuilder)
```
like the one in line 923.
If I misunderstood your point, please let me know. Thank you again for your
help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
