jackye1995 commented on code in PR #5787:
URL: https://github.com/apache/iceberg/pull/5787#discussion_r979088849
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -975,4 +1008,19 @@ private <T extends SdkClientBuilder> void
configureEndpoint(T builder, String en
builder.endpointOverride(URI.create(endpoint));
}
}
+
+ @VisibleForTesting
+ <T extends ApacheHttpClient.Builder> void configureApacheHttpClientBuilder(T
builder) {
+ boolean setConnectionTimeout = apacheHttpClientConnectionTimeout != null;
+ boolean setSocketTimeout = apacheHttpClientSocketTimeout != null;
+ if (setConnectionTimeout && setSocketTimeout) {
+ builder
Review Comment:
we don't need to do this, when you do `builder.xxxx` it automatically
mutates the builder itself. Returning itself is just to facilitate method
chaining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
