rdblue commented on code in PR #5845:
URL: https://github.com/apache/iceberg/pull/5845#discussion_r989543235
##########
python/pyiceberg/expressions/base.py:
##########
@@ -867,3 +875,196 @@ def visit_unbound_predicate(self, predicate) ->
BooleanExpression:
def visit_bound_predicate(self, predicate) -> BooleanExpression:
return predicate
+
+
+ROWS_MIGHT_MATCH = True
+ROWS_CANNOT_MATCH = False
+IN_PREDICATE_LIMIT = 200
+
+
+def _from_byte_buffer(field_type: IcebergType, val: bytes):
+ if not isinstance(field_type, PrimitiveType):
+ raise ValueError(f"Expected a PrimitiveType, got: {type(field_type)}")
+ return from_bytes(field_type, val)
+
+
+class ManifestEvaluator(BoundBooleanExpressionVisitor[bool]):
+ partition_fields: list[PartitionFieldSummary]
+ partition_filter: BooleanExpression
+
+ def __init__(self, schema: Schema, partition_filter: UnboundPredicate,
case_sensitive: bool = True):
Review Comment:
It is unlikely that this is going to be a `Schema` because it will be the
partition type produced by #5929.
I think what we want instead is to pass the Schema and the PartitionSpec to
produce the type that the expression should be bound to.
Confusing a data filter (bound to Schema) with a partition filter (bound to
partition type) is something that we want to avoid and is why there are static
factory methods in the Java code. This is okay, but we will need to be careful
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
