rdblue commented on code in PR #5845:
URL: https://github.com/apache/iceberg/pull/5845#discussion_r989543850
##########
python/pyiceberg/expressions/base.py:
##########
@@ -867,3 +875,196 @@ def visit_unbound_predicate(self, predicate) ->
BooleanExpression:
def visit_bound_predicate(self, predicate) -> BooleanExpression:
return predicate
+
+
+ROWS_MIGHT_MATCH = True
+ROWS_CANNOT_MATCH = False
+IN_PREDICATE_LIMIT = 200
+
+
+def _from_byte_buffer(field_type: IcebergType, val: bytes):
+ if not isinstance(field_type, PrimitiveType):
+ raise ValueError(f"Expected a PrimitiveType, got: {type(field_type)}")
+ return from_bytes(field_type, val)
+
+
+class ManifestEvaluator(BoundBooleanExpressionVisitor[bool]):
Review Comment:
It's okay to combine these, but it does seem a little strange to expose so
much in the public `ManifestEvaluator`. I somewhat prefer using a separate
`_ManifestEvalVisitor` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
