rdblue commented on code in PR #5845:
URL: https://github.com/apache/iceberg/pull/5845#discussion_r989544775
##########
python/tests/expressions/test_expressions_base.py:
##########
@@ -1368,6 +1381,841 @@ def
test_bound_boolean_expression_visitor_raise_on_unbound_predicate():
assert "Not a bound predicate" in str(exc_info.value)
+def _to_byte_buffer(field_type: IcebergType, val: Any):
Review Comment:
`base` is getting a bit big. Can we refactor it soon?
* `__init__.py` with the unbound expression classes
* `visitors.py` with visitor methods and base classes
* `bound.py` with bound expression classes (and maybe the binding-related
visitors?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
