ajantha-bhat commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1129867182
##########
core/src/main/java/org/apache/iceberg/actions/BaseExpireSnapshotsActionResult.java:
##########
@@ -46,6 +48,22 @@ public BaseExpireSnapshotsActionResult(
this.deletedEqDeleteFilesCount = deletedEqDeleteFilesCount;
this.deletedManifestsCount = deletedManifestsCount;
this.deletedManifestListsCount = deletedManifestListsCount;
+ this.deletedStatisticsFilesCount = 0;
+ }
+
+ public BaseExpireSnapshotsActionResult(
Review Comment:
I understood the deprecation part. Can you please elaborate on
> no longer make the new ones public? If there is an interface, then there's
no need for this class or its constructors to be public.
`BaseExpireSnapshotsActionResult` is used outside the package (in
iceberg-spark). So, I still think it needs to be public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
