ajantha-bhat commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1131281800
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -268,11 +268,67 @@ private ExpireSnapshots.Result
deleteFiles(Iterator<FileInfo> files) {
DeleteSummary summary = deleteFiles(deleteExecutorService, deleteFunc,
files);
LOG.info("Deleted {} total files", summary.totalFilesCount());
- return new BaseExpireSnapshotsActionResult(
+ return new ExpireSnapshotsActionResult(
summary.dataFilesCount(),
summary.positionDeleteFilesCount(),
summary.equalityDeleteFilesCount(),
summary.manifestsCount(),
- summary.manifestListsCount());
+ summary.manifestListsCount(),
+ summary.statisticsFilesCount());
+ }
+
+ private static class ExpireSnapshotsActionResult implements
ExpireSnapshots.Result {
Review Comment:
I tried it first but didn't give `@Value.Default`. So, the builder was not
showing it. Hence I left it. I can do this.
BTW I am stuck with debugging a flaky test (which fails after 47 minutes of
CI run). Locally it passes. Hope I am close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
