ajantha-bhat commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1131973689
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -200,6 +203,18 @@ protected Dataset<FileInfo> manifestListDS(Table table,
Set<Long> snapshotIds) {
return toFileInfoDS(manifestLists, MANIFEST_LIST);
}
+ protected Dataset<FileInfo> statisticsFileDS(Table table, Set<Long>
snapshotIds) {
+ Predicate<StatisticsFile> predicate;
+ if (snapshotIds == null) {
Review Comment:
I originally coded it to be the same style as `manifestListLocations`. Then
@jackye1995 gave a comment to change this to accept predicate. I felt the
general predicate is nice. So, I updated it.
If the user wants to filter based on path or blob metadata, no change is
required in the future if we support the predicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
