ajantha-bhat commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1132005905
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -276,12 +277,13 @@ private ExpireSnapshots.Result
deleteFiles(Iterator<FileInfo> files) {
}
LOG.info("Deleted {} total files", summary.totalFilesCount());
-
- return new BaseExpireSnapshotsActionResult(
- summary.dataFilesCount(),
- summary.positionDeleteFilesCount(),
- summary.equalityDeleteFilesCount(),
- summary.manifestsCount(),
- summary.manifestListsCount());
+ return ImmutableResult.builder()
Review Comment:
good catch. I will check if it is possible to alter the generated class name
or include the outer class name.
If I don't find anything in a few hours, I will just use a new private Inner
class in `ExpireSnapshotsSparkAction.java`.
Later It can be easily replaced (as it is private) with `Immutables` once we
have better ways in a follow-up PR.
I don't want to block this PR (targeted for 1.2.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
