ajantha-bhat commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1132084977
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -276,12 +277,13 @@ private ExpireSnapshots.Result
deleteFiles(Iterator<FileInfo> files) {
}
LOG.info("Deleted {} total files", summary.totalFilesCount());
-
- return new BaseExpireSnapshotsActionResult(
- summary.dataFilesCount(),
- summary.positionDeleteFilesCount(),
- summary.equalityDeleteFilesCount(),
- summary.manifestsCount(),
- summary.manifestListsCount());
+ return ImmutableResult.builder()
Review Comment:
Used `@Value.Enclosing` So that builder looks like
`ImmutableExpireSnapshots.Result.builder()` now.
In a follow-up PR, I plan to deprecate all public result classes of actions
and use `immutables` annotation for actions to build result objects from that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
