singhpk234 commented on code in PR #7391:
URL: https://github.com/apache/iceberg/pull/7391#discussion_r1174529831
##########
build.gradle:
##########
@@ -68,10 +68,36 @@ try {
if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
project.ext.jdkVersion = '8'
+ project.ext.extraJvmArgs = []
} else if (JavaVersion.current() == JavaVersion.VERSION_11) {
project.ext.jdkVersion = '11'
+ project.ext.extraJvmArgs = []
+} else if (JavaVersion.current() == JavaVersion.VERSION_17) {
+ project.ext.jdkVersion = '17'
+ project.ext.extraJvmArgs = ["-XX:+IgnoreUnrecognizedVMOptions",
+ "--add-opens", "java.base/java.io=ALL-UNNAMED",
Review Comment:
I collected these flag by debugging individual failures of ut's from test
projects (spark / arrow / aws (kryo)) this is a superset i would say we may
define only the relevant one's per package, but since there was no harm in
passing additional flags hence passed all the flags in all the projects. please
let me know your thoughts if the above makes sense, happy to add required flags
per projects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
