jackye1995 commented on code in PR #7391:
URL: https://github.com/apache/iceberg/pull/7391#discussion_r1175548330
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestMetadataTableReadableMetrics.java:
##########
@@ -76,6 +77,8 @@ public class TestMetadataTableReadableMetrics extends
SparkTestBaseWithCatalog {
optional(8, "fixedCol", Types.FixedType.ofLength(3)),
optional(9, "binaryCol", Types.BinaryType.get()));
+ private DataFile dataFile;
Review Comment:
Why do we need to make this change? I thought as long as we remove the
hard-coded stats it's good enough. If it's only for styling, it feels to me
that having this as a local variable is better compared to a shared
uninitialized instance variable across different tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
