jackye1995 commented on code in PR #7391:
URL: https://github.com/apache/iceberg/pull/7391#discussion_r1175787399
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestMetadataTableReadableMetrics.java:
##########
@@ -76,6 +77,8 @@ public class TestMetadataTableReadableMetrics extends
SparkTestBaseWithCatalog {
optional(8, "fixedCol", Types.FixedType.ofLength(3)),
optional(9, "binaryCol", Types.BinaryType.get()));
+ private DataFile dataFile;
Review Comment:
I see. I read the full tests, technically we could also let
`createPrimitiveTable` and `createNestedTable` return `Pair<Table, DataFile>`
so the individual methods could access both the table (which is not really used
today) and also the associated data files. I think this has the benefit that if
we want to enable parallel execution of tests it won't get in our way. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
