singhpk234 commented on code in PR #7391:
URL: https://github.com/apache/iceberg/pull/7391#discussion_r1175557969
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestMetadataTableReadableMetrics.java:
##########
@@ -76,6 +77,8 @@ public class TestMetadataTableReadableMetrics extends
SparkTestBaseWithCatalog {
optional(8, "fixedCol", Types.FixedType.ofLength(3)),
optional(9, "binaryCol", Types.BinaryType.get()));
+ private DataFile dataFile;
Review Comment:
Making this as a class member helped as we create the data file and table
obj both in the createPrimitiveTable and createNestedTable methods directly,
which makes both table / data file obj non-accessible in the ut, by making it a
class member we can avoid logic of recreation of these obj in the UT and
directly reference it in the test. Hence made it like above. Please let me know
your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
