[
https://issues.apache.org/jira/browse/IGNITE-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809095#comment-16809095
]
Ivan Pavlukhin commented on IGNITE-11412:
-----------------------------------------
[~ivanan.fed], I am looking at
{{TestJUnit3TestLegacySupport/TestConditionsAware}} class and cannot figure out
it purpose. Currently it contains definitions of our custom _before/after_
methods and a {{getName}} method. And it is funny that _before/after_ methods
are not used in that class at all. I think that we can get rid of this class
and put it's content into {{GridAbstractTest}}. What do you think about it?
Another minor but in my mind useful thing is renaming
{{GridAbstractTest.setUp/tearDown}} to something more specific to avoid
confustion with standard junit {{setUp/tearDown}}. I can imagine naming like
{{setUp -> prepareTestEnvironment, tearDown -> cleanupTestEnvironment}}.
> Actualize JUnit3TestLegacySupport class
> ---------------------------------------
>
> Key: IGNITE-11412
> URL: https://issues.apache.org/jira/browse/IGNITE-11412
> Project: Ignite
> Issue Type: Improvement
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Major
> Labels: iep-30
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Specify JUnit3TestLegacySupport class documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
