mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469565524
##########
File path:
lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java
##########
@@ -68,10 +68,12 @@ public int compareValues(T first, T second) {
* @param comparator – comparator to wrap
* @param reverse – if this sort is reverse
* @param singleSort – true if this sort is based on a single field and
there are no other sort fields for tie breaking
+ * @param hasAfter – true if this sort has after FieldDoc
* @return comparator wrapped as a filtering comparator or the original
comparator if the filtering functionality
* is not implemented for it
*/
- public static FieldComparator<?>
wrapToFilteringComparator(FieldComparator<?> comparator, boolean reverse,
boolean singleSort) {
+ public static FieldComparator<?>
wrapToFilteringComparator(FieldComparator<?> comparator, boolean reverse,
boolean singleSort,
+ boolean hasAfter) {
Review comment:
At that moment topValue is not set yet, it will be set later in the
constructor of `PagingFieldCollector`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
