mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504337
##########
File path:
lucene/core/src/java/org/apache/lucene/search/FilteringLeafFieldComparator.java
##########
@@ -32,8 +33,22 @@
DocIdSetIterator competitiveIterator() throws IOException;
/**
- * Informs this leaf comparator that it is allowed to start updating its
competitive iterator.
- * This method is called from a collector when queue becomes full and
threshold is reached.
+ * Informs this leaf comparator that hits threshold is reached.
+ * This method is called from a collector when hits threshold is reached.
+ * For some filtering comparators (e.g. {@code FilteringDocLeafComparator}
reaching
+ * hits threshold is enough to start updating their iterators, even when
queue is not yet full.
*/
- void setCanUpdateIterator() throws IOException;
+ void setHitsThresholdReached() throws IOException;
+
+ /**
+ * Informs this leaf comparator that queue has become full.
+ * This method is called from a collector when queue becomes full.
+ */
+ void setQueueFull() throws IOException;
Review comment:
addressed in 746c8fa
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
