mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469566632
##########
File path: lucene/core/src/java/org/apache/lucene/search/FieldValueHitQueue.java
##########
@@ -121,7 +121,7 @@ protected boolean lessThan(final Entry hitA, final Entry
hitB) {
}
// prevent instantiation and extension.
- private FieldValueHitQueue(SortField[] fields, int size, boolean
filterNonCompetitiveDocs) {
+ private FieldValueHitQueue(SortField[] fields, int size, boolean
filterNonCompetitiveDocs, boolean hasAfter) {
Review comment:
At this point of time, topValue for comparators is not set yet, that's
why we need `hasAfter`.
As an alternative to this implementation, we can pass `FieldDoc after` to
`FieldValueHitQueue.create` and setTopValue during `FieldValueHitQueue`
creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
