[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

[GitBox]

mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504436



##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -150,11 +150,15 @@ public void setScorer(Scorable scorer) throws IOException 
{
       if (minScoreAcc != null) {
         updateGlobalMinCompetitiveScore(scorer);
       }
-      if (filteringLeafComparator != null && queueFull && 
hitsThresholdChecker.isThresholdReached()) {
-        // if queue became full and hitsThreshold was reached in previous 
segments,
-        // notify this segment's leaf comparator that its competitive iterator 
can be updated
-        filteringLeafComparator.setCanUpdateIterator();
-        totalHitsRelation = TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO;
+
+      if (filteringLeafComparator != null && 
hitsThresholdChecker.isThresholdReached()) {
+        // hitsThreshold was reached in previous segments, notify this 
segment's leaf comparator about it
+        filteringLeafComparator.setHitsThresholdReached();
+        // if queue became full in previous segments, notify this segment's 
leaf comparator about it
+        if (queueFull) filteringLeafComparator.setQueueFull();
+        if (filteringLeafComparator.iteratorUpdated()) {
+          totalHitsRelation = TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO;
+        }

Review comment:
       addressed in 746c8fa




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org