Pulkitg64 commented on code in PR #16473:
URL: https://github.com/apache/lucene/pull/16473#discussion_r3814493714
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsWriter.java:
##########
@@ -571,26 +597,55 @@ public boolean isFinished() {
return finished && flatFieldVectorsWriter.isFinished();
}
- @Override
- public void addValue(int docID, float[] vectorValue) throws IOException {
- flatFieldVectorsWriter.addValue(docID, vectorValue);
+ /** The ordinal's stored vector as fp32, ready for quantization
(unit-length for COSINE). */
Review Comment:
adding in comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
