Pulkitg64 commented on code in PR #16473:
URL: https://github.com/apache/lucene/pull/16473#discussion_r3814501661
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/OffHeapScalarQuantizedVectorValues.java:
##########
@@ -447,6 +472,31 @@ public VectorScorer.Bulk bulk(DocIdSetIterator
matchingDocs) {
}
};
}
+
+ @Override
+ public VectorScorer scorer(short[] target) throws IOException {
+ assert isQuerySide == false;
+ SparseOffHeapVectorValues copy = copy();
+ DocIndexIterator iterator = copy.iterator();
+ RandomVectorScorer scorer =
+ vectorsScorer.getRandomVectorScorer(similarityFunction, copy,
target);
+ return new VectorScorer() {
Review Comment:
I agree that there is lot of duplicate codes with this change :(( I can try
to simplify the code as part of separate change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
