msokolov commented on code in PR #16473:
URL: https://github.com/apache/lucene/pull/16473#discussion_r3816717059
##########
lucene/core/src/test/org/apache/lucene/codecs/lucene104/TestLucene104ScalarQuantizedVectorsFormat.java:
##########
@@ -214,6 +264,256 @@ public void testQuantizedVectorsWriteAndRead() throws
IOException {
}
}
+ /**
+ * fp16 counterpart of {@link #testQuantizedVectorsWriteAndRead()}: indexes
float16 vectors and
+ * verifies the persisted quantized bytes + corrective terms match a
reference re-quantization.
+ * The reference mirrors the writer's fp16 path exactly — inflate
fp16->fp32 (normalizing
Review Comment:
oh funny, it actually seemed fine and I thought you wrote it. I was just
poking fun at the emdash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
