javanna commented on code in PR #16741:
URL: https://github.com/apache/lucene/pull/16741#discussion_r4165538916
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestAncientIndicesCompatibility.java:
##########
@@ -199,18 +199,23 @@ public void testUnsupportedOldIndexes() throws Exception {
checker.setInfoStream(new PrintStream(bos, false, UTF_8));
checker.setLevel(CheckIndex.Level.MIN_LEVEL_FOR_INTEGRITY_CHECKS);
CheckIndex.Status indexStatus = checker.checkIndex();
+ // TODO this conditional is no longer exercised.
+ // It would only be needed in the future for versions that can only be
+ // read via expert API (hence their codecs are maintained), but can't be
written into.
+ /*
Review Comment:
I checked this: in practice, this is just a hardcoded version of the min
binary supported major, that is now going away in favor of min supported major
(as this PR brings it one major back).
The conditional was there because there used to be some unsupported indices
that check index would not fail opening, as codecs were shipped with the
current release (8.x with Lucene 10.x, 9.x with Lucene 11.x).
I concluded that we don't need this conditional with the changes that this
PR brings in, as we are removing the distinction between the two min major
versions. All supported indices are now listed under supported, and all the
unsupported indices will fail check index as well as opening a writer against
them. there's no middle ground anymore, which is much easier to follow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
