javanna commented on code in PR #16741:
URL: https://github.com/apache/lucene/pull/16741#discussion_r4166381744
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestDVUpdateBackwardsCompatibility.java:
##########
@@ -53,13 +51,13 @@ public TestDVUpdateBackwardsCompatibility(Version version,
String pattern) {
super(version, pattern);
}
- /** Provides the initial release of the previous major to the test-framework
*/
+ /**
+ * Indexes are generated only at the first release of each major. The
factory fails if any
+ * supported major is missing so coverage cannot be dropped by deleting a
version from a list.
+ */
@ParametersFactory(argumentFormatting = "Lucene-Version:%1$s; Pattern: %2$s")
public static Iterable<Object[]> testVersionsFactory() {
- List<Object[]> params = new ArrayList<>();
- // TODO - WHY ONLY on the first major version?
- params.add(new Object[] {Version.LUCENE_10_0_0, createPattern(INDEX_NAME,
SUFFIX)});
- return params;
+ return allInitialMajorVersion(INDEX_NAME, SUFFIX);
Review Comment:
this is now generalized rather than hardcoded. It should no longer require
manual action when min support version changes in the future. Same for the
following two test classes. TODO is now obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
