javanna commented on code in PR #16741:
URL: https://github.com/apache/lucene/pull/16741#discussion_r4228640480
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBasicBackwardsCompatibility.java:
##########
@@ -871,11 +873,11 @@ public void testFailOpenOldIndex() throws IOException {
public void testOpenModeAndCreatedVersion() throws IOException {
Directory dir = newDirectory(directory);
int majorVersion =
SegmentInfos.readLatestCommit(dir).getIndexCreatedVersionMajor();
- if (majorVersion != Version.MIN_SUPPORTED_MAJOR && majorVersion !=
Version.LATEST.major) {
+ if (majorVersion < Version.MIN_SUPPORTED_MAJOR || majorVersion >
Version.LATEST.major) {
Review Comment:
Hey @rahulgoswami thanks for taking a look! I am not sure if you are
suggesting further edits to my PR., to replace the way we do min version
checks. If so, could you make those as a follow-up, or are they necessary to
make as part of this PR? It's already a significant change as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
