javanna commented on PR #16741:
URL: https://github.com/apache/lucene/pull/16741#issuecomment-6122594044
> Let's look at it in a follow-up, but I think maybe we don't even need the
minimum supported version constant at all now? There's the hard-coded 7.4 lower
bound that SegmentInfos needs, but other than that, if you have a Codec on your
classpath that can read a segment then I don't think there's a reason for
lucene to refuse to open it.
I agree, it is worth double checking as a follow-up the version checks and
consider further simplifications. There's two checks:
- write side: `IndexWriterConfig#setIndexCreatedVersionMajor`
- read side: `SegmentInfos` - removing this check would allow us to remove
the expert `SegmentInfos#readCommit(
Directory directory, String segmentFileName, int
minSupportedMajorVersion)` API in favour of the ordinary variant that does not
take the min support version as last argument.
I will put up a proposal once this PR lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
