[
https://issues.apache.org/jira/browse/LUCY-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229008#comment-15229008
]
ASF GitHub Bot commented on LUCY-295:
-------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/38
LUCY-295 Change I32Array to use size_t
Change I32Array so that it uses a size_t to index into its array of 32-bit
integers. This entails both changes to the class internals and to the internal
API. (I32Array is not a public API.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-295-i32array-size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 7e31cc6930fe9c78b9a21124765dc33a98d10759
Author: Marvin Humphrey <[email protected]>
Date: 2016-03-31T00:34:19Z
Change I32Array size to `size_t`.
Only the core module -- all usage sites need to be changed next.
commit 0c494085ac98a77d7969f1a385be1bf39936bb2e
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-06T00:47:50Z
Adapt Perl bindings for I32Array size change.
commit bb4f6e44bc55664f7ac4ec5e3c318619ffa6f8f2
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-06T02:02:38Z
Adapt PolyReader_sub_tick for changes to I32Array.
commit ffb3c830ac57fd5d94b24b1ad438542238b8ac84
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-06T02:05:43Z
Adapt PhraseQuery, ProximityQuery for I32Array.
Adapt these two very similar Query subclasses for the I32Array size
change.
commit 3f0e59ba8f3f7c99f6ea8950d48c4fcd28a700b9
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-06T02:09:54Z
Adapt calls into I32Array APIs for size change.
Add/remove casts for functions where the width of a size argument has
changed.
commit e7b501caf3e6b6672f7c888e3fadecb30d07b360
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-06T02:14:53Z
Various adaptations to I32Array size change.
These changes are a grab bag, some of which are easy to review and some
of which are more subtle.
----
> Address integer conversion compiler warnings
> --------------------------------------------
>
> Key: LUCY-295
> URL: https://issues.apache.org/jira/browse/LUCY-295
> Project: Lucy
> Issue Type: Improvement
> Components: Core
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Priority: Minor
> Fix For: 0.6.0
>
>
> Enabling `-Wconversion` reveals a fairly large number of warnings. Most are
> harmless and just require an inconsequential type change or a cast. Some are
> best fixed with API changes. There may be some bugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
