[
https://issues.apache.org/jira/browse/LUCY-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257401#comment-15257401
]
ASF GitHub Bot commented on LUCY-295:
-------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/44
LUCY-295 More Clownfish size_t adaptations
Adapt Lucy code for better conformance with Clownfish APIs -- in
particular, those that have changed to use size_t for element counts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-295-more-cf-size_t
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit 30663d768a85f5cdf55b4c29026954280d68269c
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T18:57:53Z
Address a few more simple Vec_Get_Size.
Adapt a few more easy-to-review transitions from uint32_t to size_t.
commit 74d7d40db233e1dbfb2c7961116607d00ddad3bf
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T19:04:35Z
Cast to narrow type from Vec_Get_Size.
Cast from size_t to uint32_t to avoid -Wconversion warnings. In each of
these cases, the number of elements in the Vector should be small.
commit bb67e9f0b737eba783f053c0f7421d71d2affb5a
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T19:32:59Z
Adapt for changes to Hash_Get_Size.
The return value has been widened to size_t, so cast where necessary.
commit 76dc745df3707ab98fbff1e6ba7abd7dc252c6ef
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T20:04:50Z
Adapt for Vec_Fetch size_t tick param.
Change variable types or cast as necessary to adapt to size_t `tick`
param to Vec_Fetch.
commit f57736f3d759eded77d52f3bcacda3e180a31b28
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T20:50:16Z
Adapt for size_t tick param to Vec_Store.
commit 90d4a7d6d4e310d9d8c0568b76c4dba246dad01f
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T22:44:05Z
Adapt for String size_t APIs.
Adapt for String methods which either return size_t or accept size_t
parameters.
commit 56cabf0ce0f827b15e666a3760cdd54ace6f5d0e
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T23:37:07Z
Adapt for Blob size_t APIs.
commit a52a0a998d6eaf97bb389d6a40c0834f3a4585a2
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-25T23:45:10Z
Adapt for size_t ByteBuf APIs.
commit beca7cbe501707c1ef9308050b83466d6547e89a
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-26T00:02:48Z
Cast arg to Int_new.
commit 7ffa1e0231508051d7f49eaa432703fa57b16fcd
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-26T01:17:08Z
Adapt for size_t StringIterator APIs.
----
> Address integer conversion compiler warnings
> --------------------------------------------
>
> Key: LUCY-295
> URL: https://issues.apache.org/jira/browse/LUCY-295
> Project: Lucy
> Issue Type: Improvement
> Components: Core
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Priority: Minor
> Fix For: 0.6.0
>
>
> Enabling `-Wconversion` reveals a fairly large number of warnings. Most are
> harmless and just require an inconsequential type change or a cast. Some are
> best fixed with API changes. There may be some bugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
