[
https://issues.apache.org/jira/browse/LUCY-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263183#comment-15263183
]
ASF GitHub Bot commented on LUCY-295:
-------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/46
LUCY-295 Adapt file position code for -Wconversion
Perform casts or variable type conversions in code manipulating file
positions in order to adapt for -Wconversion.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-295-file-pos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit e629483e624bb6a701ff39b37ba7f4e09fd63140
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-28T00:57:55Z
Change `len` param to int64_t for internal read.
Use int64_t rather than size_t to make overflow checking easier.
commit e9afedbfdec345099cc47922ea4cabc34273dee7
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-28T22:08:36Z
Change internal size_t to int64_t in OutStream.
commit cc9a8169112df6989ec32d6c357ca63d0837773c
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-28T22:13:31Z
Cast or convert integers holding file positions.
Perform casts or change variable types to make code manipulating file
positions compliant with -Wconversion.
----
> Address integer conversion compiler warnings
> --------------------------------------------
>
> Key: LUCY-295
> URL: https://issues.apache.org/jira/browse/LUCY-295
> Project: Lucy
> Issue Type: Improvement
> Components: Core
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Priority: Minor
> Fix For: 0.6.0
>
>
> Enabling `-Wconversion` reveals a fairly large number of warnings. Most are
> harmless and just require an inconsequential type change or a cast. Some are
> best fixed with API changes. There may be some bugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
