[
https://issues.apache.org/jira/browse/LUCY-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259338#comment-15259338
]
ASF GitHub Bot commented on LUCY-295:
-------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/45
LUCY-295 Fix int types in unit tests
Fix -Wconversion warnings in the Lucy unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-295-tests-int-types
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit bbac126ab9d815d8519dfe3f008db572a3ea4305
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-26T22:43:31Z
Switch test macro from signed to unsigned.
Use TEST_UINT_EQ instead of TEST_INT_EQ as needed.
commit 641449dfe744acce2bcee78f7312d40fbf90dd04
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-27T01:03:08Z
Be consistent about using correct integer type.
commit 882fbc1e9e0006e79d4eaaacef8f30444e88c924
Author: Marvin Humphrey <[email protected]>
Date: 2016-04-27T01:05:44Z
Make straightforward int type adjustments.
Either cast or change types to quiet -Wconversion warnings.
----
> Address integer conversion compiler warnings
> --------------------------------------------
>
> Key: LUCY-295
> URL: https://issues.apache.org/jira/browse/LUCY-295
> Project: Lucy
> Issue Type: Improvement
> Components: Core
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Priority: Minor
> Fix For: 0.6.0
>
>
> Enabling `-Wconversion` reveals a fairly large number of warnings. Most are
> harmless and just require an inconsequential type change or a cast. Some are
> best fixed with API changes. There may be some bugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
