bmarwell commented on a change in pull request #16:
URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526679134
##########
File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
##########
@@ -443,15 +416,14 @@ public void execute()
return modulepathElements;
}
- private String getExecutable()
- throws MojoFailureException
+ private JLinkExecutor getExecutor() throws MojoFailureException
{
- String jLinkExec;
+ JLinkExecutor jLinkExec;
try
{
- jLinkExec = getJLinkExecutable();
+ jLinkExec = getJlinkExecutor();
Review comment:
This is also something not in the scope of the PR. You are asking me to
do a full refactoring here, while I only want to introduce ToolProvider. This
line you marked is exactly as the existing code. Please file a JIRA issue and
lets create a new PR for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
