bmarwell commented on a change in pull request #16:
URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526959284



##########
File path: 
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##########
@@ -0,0 +1,204 @@
+package org.apache.maven.plugins.jlink;
+
+/*

Review comment:
       Actually, you can figure out which checks are being enforced this way:
   
   ```
   (user@host)[~/git/apache/maven-jlink-plugin]$ mvn help:effective-pom
   [INFO] Scanning for projects...
   [INFO] 
   [INFO] ------------< org.apache.maven.plugins:maven-jlink-plugin 
>-------------
   [INFO] Building Apache Maven JLink Plugin 3.0.1-SNAPSHOT
   [INFO] ----------------------------[ maven-plugin 
]----------------------------
   [INFO] 
   [INFO] --- maven-help-plugin:3.2.0:effective-pom (default-cli) @ 
maven-jlink-plugin ---
   Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-model/3.6.1/maven-model-3.6.1.pom
   Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-model/3.6.1/maven-model-3.6.1.pom
 (4.0 kB at 5.7 kB/s)
   Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven/3.6.1/maven-3.6.1.pom
   Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven/3.6.1/maven-3.6.1.pom
 (24 kB at 523 kB/s)
   Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-model/3.6.1/maven-model-3.6.1.jar
   Downloaded from central: 
https://repo.maven.apache.org/maven2/org/apache/maven/maven-model/3.6.1/maven-model-3.6.1.jar
 (186 kB at 2.2 MB/s)
   [INFO] 
   Effective POMs, after inheritance, interpolation, and profiles are applied:
   
   […]
           <plugin>
             <artifactId>maven-checkstyle-plugin</artifactId>
             <version>3.0.0</version>
             <dependencies>
               <dependency>
                 <groupId>org.apache.maven.shared</groupId>
                 <artifactId>maven-shared-resources</artifactId>
                 <version>2</version>
                 <scope>compile</scope>
               </dependency>
             </dependencies>
             <configuration>
               <configLocation>config/maven_checks.xml</configLocation>
               <headerLocation>config/maven-header.txt</headerLocation>
   […]
   ```
   
   Then: 
https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven-header.txt
   
   HTH




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to