bmarwell commented on a change in pull request #16:
URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526681588
##########
File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
##########
@@ -443,15 +416,14 @@ public void execute()
return modulepathElements;
}
- private String getExecutable()
- throws MojoFailureException
+ private JLinkExecutor getExecutor() throws MojoFailureException
{
- String jLinkExec;
+ JLinkExecutor jLinkExec;
try
{
- jLinkExec = getJLinkExecutable();
+ jLinkExec = getJlinkExecutor();
}
- catch ( IOException e )
+ catch ( RuntimeException e )
Review comment:
Done. Moved this outdated try-catch to the execution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
