bmarwell commented on pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-730223612
@elharo while agree with **everything** you wrote, I do not want to change any algorithms, methods etc. for this method. You had a chance to review these things earlier in the development phase. I did not introduce them, and I will keep them as I do not want to touch any of the inner logic. Please see my comments and open separate JIRA issues for each of them. Thanks for pointing out the unnecessary constructor and try-catch though. I fixed them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
