elharo commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2793481668


##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -693,27 +693,27 @@ private void initProject(MavenProject project, 
ModelBuilderResult result) {
 
                 /*
                  * `sourceDirectory`, `testSourceDirectory` and 
`scriptSourceDirectory`
-                 * are ignored if the POM file contains at least one enabled 
<source> element
+                 * are not used if the POM file contains at least one enabled 
<source> element

Review Comment:
   I'm not fully up to speed on all of this. I try to avoid modules. However, 
the general principle I would follow is that if the client project contains 
code or resources that the developer likely intended to be included and for 
some reason we are not including it, then Maven should hard fail the build. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to