ascheman commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2793524331
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -693,27 +693,27 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
/*
* `sourceDirectory`, `testSourceDirectory` and
`scriptSourceDirectory`
- * are ignored if the POM file contains at least one enabled
<source> element
+ * are not used if the POM file contains at least one enabled
<source> element
Review Comment:
I think we are totally with you, @elharo: Mixing things up, in particular if
they lead to silent ignores (as in the first versions of the implementation)
should lead to hard failures. IIRC we wanted to allow for a smooth migration if
people start to work with the new module source hiearchy. However, as all of
this is completely new (with Maven 4), we should take the opportunity to make
such mixed POM specifications hard errors and not let people think they can
somehow use both. They have to make a decision to either have a legacy layout
or use the new opportunities.
Having said that, we seem to have forgot some combinations in the POM which
are handled inconsistent. Happy for your critical thinking and detection of
these during the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
