ascheman commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2794078939
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -693,27 +693,27 @@ private void initProject(MavenProject project,
ModelBuilderResult result) {
/*
* `sourceDirectory`, `testSourceDirectory` and
`scriptSourceDirectory`
- * are ignored if the POM file contains at least one enabled
<source> element
+ * are not used if the POM file contains at least one enabled
<source> element
Review Comment:
While working on the change, I would like to re-formulate
[AC9](https://github.com/apache/maven/issues/11701#issuecomment-3884782347) to
be even more strict: Once you use `<sources>` on your project, you ~~must not~~
_cannot_ use legacy `<sourceDirectory>` / `<testSourceDirectory>` any longer,
even if they point to the same implicit (e.g., `src/main/java`) or explicit
directory (have the same value for the same directory/scope/language
combination). What do you think, @elharo and @desruisseaux ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
