gnodet-bot commented on PR #13233: URL: https://github.com/apache/maven/pull/13233#issuecomment-5771996894
**Missing tests (blocking)** The feature touches two independent code paths — `DefaultLifecycleExecutionPlanCalculator` (sequential) and `BuildPlanExecutor` (concurrent) — and neither has a test for the new skip logic. `DefaultLifecycleExecutionPlanCalculatorTest` and `BuildPlanExecutorTest` were not modified. At minimum needed: 1. A unit test in `DefaultLifecycleExecutionPlanCalculatorTest` verifying that mojos bound to a skipped phase are excluded from the returned list while mojos bound to other phases are not. 2. A unit test in `BuildPlanExecutorTest` (or a new `SkipPhasesTest`) verifying the concurrent path behaves identically. 3. An integration test (IT) under `its/core-it-suite/` covering an end-to-end scenario: `mvn verify --skip-phases=test` where a test plugin is bound to the `test` phase confirms it does not run, but `verify`-bound mojos do. Without tests, the next rebase that changes the phase resolution order or the `plan()` inner class structure will silently break this feature. _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
