gnodet commented on code in PR #13233:
URL: https://github.com/apache/maven/pull/13233#discussion_r4069018924
##########
impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanExecutor.java:
##########
@@ -619,6 +620,7 @@ private Clock getClock(Object key) {
private void plan() {
lock.writeLock().lock();
try {
+ Set<String> skippedPhases = new
HashSet<>(session.getRequest().getSkippedPhases());
Review Comment:
Fixed in a494d37554. Added the same null guard as the sequential path:
`session.getRequest() != null ? new HashSet<>(...) : Set.of()`.
##########
impl/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##########
@@ -121,6 +121,11 @@ public interface MavenExecutionRequest {
List<String> getGoals();
+ // Skipped phases
+ MavenExecutionRequest setSkippedPhases(List<String> skippedPhases);
+
+ List<String> getSkippedPhases();
Review Comment:
Fixed in a494d37554. Full Javadoc with `@param`, `@return`, and `@since
4.1.0` added to both methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
