gnodet-bot commented on PR #13233:
URL: https://github.com/apache/maven/pull/13233#issuecomment-5772265672
**`BuildPlanExecutorTest` — concurrent skip-phases path untested.**
`BuildPlanExecutorTest` was not modified in this PR. The filtering logic in
`BuildPlanExecutor.plan()` (the `if (skippedPhases.contains(resolvedPhase)) {
continue; }` block added to the `plan()` inner class) is completely untested.
This is the more critical path to test: the concurrent builder is the
default in Maven 4 when `-T` is used, and the `plan()` method runs inside a
write-lock loop with complex predecessor/step tracking. A test should verify
that a mojo bound to a skipped phase is not added to the plan's step list while
mojos bound to non-skipped phases are still present.
Please add a test to `BuildPlanExecutorTest` covering at least:
1. A mojo bound to a skipped phase is excluded from the build plan.
2. A mojo bound to a non-skipped phase runs normally.
_This review was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
