michael-o commented on code in PR #854:
URL:
https://github.com/apache/maven-shade-plugin/pull/854#discussion_r4069121004
##########
src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java:
##########
@@ -222,11 +221,11 @@ private boolean removeServicesFromJar(Clazzpath cp,
Set<Clazz> neededClasses, St
// check whether the found classes use services in turn
repeatScan = scanServiceProviderConfigFile(cp,
configFileReader);
} catch (final IOException e) {
- log.warn(e.getMessage());
+ log.warn("Failed to scan JAR entry " + jarEntry.getName(),
e);
Review Comment:
Agreed on the message, but not on the second statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
