ikxeno commented on code in PR #13276: URL: https://github.com/apache/maven/pull/13276#discussion_r4116397507
########## impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvnval/CommonsCliValidateOptionsTest.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 Review Comment: Every Java file in the tree uses the http form: ``` $ grep -rl 'http://www.apache.org/licenses/LICENSE-2.0' --include='.java' | wc -l 1322 $ grep -rl 'https://www.apache.org/licenses/LICENSE-2.0' --include='.java' | wc -l 0 ``` So the new files match their neighbours rather than starting a second style. If the project wants https, that's a tree-wide change and I'll do it as its own PR. Tell me which you prefer and I'll follow it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
