ikxeno commented on code in PR #13276: URL: https://github.com/apache/maven/pull/13276#discussion_r4116409625
########## apache-maven/src/assembly/maven/bin/mvnval.cmd: ########## @@ -0,0 +1,39 @@ +@REM Licensed to the Apache Software Foundation (ASF) under one +@REM or more contributor license agreements. See the NOTICE file +@REM distributed with this work for additional information +@REM regarding copyright ownership. The ASF licenses this file +@REM to you under the Apache License, Version 2.0 (the +@REM "License"); you may not use this file except in compliance +@REM with the License. You may obtain a copy of the License at +@REM +@REM http://www.apache.org/licenses/LICENSE-2.0 +@REM +@REM Unless required by applicable law or agreed to in writing, +@REM software distributed under the License is distributed on an +@REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +@REM KIND, either express or implied. See the License for the +@REM specific language governing permissions and limitations +@REM under the License. + +@REM ----------------------------------------------------------------------------- +@REM Apache Maven POM Validation Script +@REM +@REM Environment Variable Prerequisites +@REM +@REM JAVA_HOME (Optional) Points to a Java installation. +@REM MAVEN_BATCH_ECHO (Optional) Set to 'on' to enable the echoing of the batch commands. Review Comment: `on` is what the other launchers say and what the code compares against: ``` mvn.cmd:25 @REM MAVEN_BATCH_ECHO (Optional) Set to 'on' to enable ... mvnenc.cmd:24 @REM MAVEN_BATCH_ECHO (Optional) Set to 'on' to enable ... mvnval.cmd:35 @if "%MAVEN_BATCH_ECHO%"=="on" echo %MAVEN_BATCH_ECHO% ``` I'd rather not make mvnval the one file that differs. Happy to move the whole set to true in a separate PR if that's what you want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
