gnodet commented on PR #13276: URL: https://github.com/apache/maven/pull/13276#issuecomment-5874820199
Thanks for addressing the rename, the cache cleanup, and the shared session — those are all improvements. On the network question: I think the default should be `--mode effective` (full effective model validation, downloading parents into the local repository as needed), with `--mode raw` as an explicit opt-out for the offline / pre-commit case. The raw mode is useful, but it's the more limited option — defaulting to it means users get incomplete validation silently. For the local repository, the default should be `~/.m2/repository` as usual, with two options: - `--local-repository <path>` / `-Dmaven.repo.local` for an explicit path - `--temp-local-repository` for a throwaway directory deleted on exit (the CI isolation case) `ApiRunner.createSession(injectorConsumer, localRepo)` already accepts the path — this is purely wiring on the `mvnval` side, no new API needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
