[ 
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432221#comment-16432221
 ] 

ASF GitHub Bot commented on METRON-1421:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/970
  
    It is definitely looking better.  I am liking the progress.  But I still 
think having overly broad interfaces that do everything is causing problems; 
primarily `IndexDao` and also `MetaAlertDao`.
    
    Neither of those need to exist.  For example...
    * The `MetaAlertService` does not need a `MetaAlertDao`.
    * If the `MetaAlertService` needs to update meta-alerts then it should 
directly use a `MetaAlertUpdateDao`.  
    * If the `MetaAlertService` needs to search for meta-alerts then it should 
directly use a `MetaAlertSearchDao`.  
    
    I can submit a PR to your branch, if you like.


> Create a SolrMetaAlertDao
> -------------------------
>
>                 Key: METRON-1421
>                 URL: https://issues.apache.org/jira/browse/METRON-1421
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve 
> implementing the various MetaAlertDao methods using the SolrJ library and 
> also providing a SolrMetaAlertIntegrationTest (similar to 
> ElasticsearchMetaAlertIntegrationTest).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to