[ 
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432539#comment-16432539
 ] 

ASF GitHub Bot commented on METRON-1421:
----------------------------------------

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/970
  
    @ottobackwards Correct me if I'm misunderstanding your view, @nickwallen, 
but the discussion is around what's the required level of iteration / 
refactoring where this meets expectations for testing and maintainability 
before this can go into the feature branch at all. I'm fine iterating 
afterwards (and that may include things like overall DAO restructuring an other 
things, depending on what ends up happening here).  What we're trying to avoid 
is a situation where we immediately want to do large scale refactoring 
immediately (whether as part of the feature branch itself or master).  This is 
(potentially) one of the final (and largest + most complicated) components of 
the feature branch, so I think that's where the concern from both myself and 
Nick is.
    
    Once this is landed (or before or whenever), we can throw whatever PRs at 
the feature branch.


> Create a SolrMetaAlertDao
> -------------------------
>
>                 Key: METRON-1421
>                 URL: https://issues.apache.org/jira/browse/METRON-1421
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve 
> implementing the various MetaAlertDao methods using the SolrJ library and 
> also providing a SolrMetaAlertIntegrationTest (similar to 
> ElasticsearchMetaAlertIntegrationTest).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to