[ 
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432312#comment-16432312
 ] 

ASF GitHub Bot commented on METRON-1421:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/970
  
    > @justinleet Solve the code reuse problem for Solr and ES.
    
    I am also noticing another positive side effect here. Getting rid of these 
interface hierarchies (like having the `MetaAlertService` use an 
`MetaAlertUpdateDao`) is that the service layer becomes where code lives that 
can be reused across ES and Solr.  And that makes a ton of logical sense to me.
    
    



> Create a SolrMetaAlertDao
> -------------------------
>
>                 Key: METRON-1421
>                 URL: https://issues.apache.org/jira/browse/METRON-1421
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve 
> implementing the various MetaAlertDao methods using the SolrJ library and 
> also providing a SolrMetaAlertIntegrationTest (similar to 
> ElasticsearchMetaAlertIntegrationTest).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to