ASF GitHub Bot commented on METRON-1421:

Github user nickwallen commented on the issue:

    Just to summarize my position, my suggested refactorings are just one of 
many ways to improve the testability of all this.  We don't have to take this 
    For this PR, I will be happy if we think we have sufficient unit test 
coverage on the functionality here.  If @justinleet thinks we are good on unit 
tests now, I will take another look at the unit tests today.
    > @justinleet:  What we're trying to avoid is a situation where we 
immediately want to do large scale refactoring immediately (whether as part of 
the feature branch itself or master).
    To be honest, ultimately, I would like to refactor this (iteratively) to be 
simpler and more testable, but it doesn't have to happen on this PR or even on 
this feature branch or even in the near-term.  I don't know when I'd be able to 
get to that.
    @justinleet What do you think is a good path forward?  I want to keep an 
open mind and make sure we're not doing more than we need to here.

> Create a SolrMetaAlertDao
> -------------------------
>                 Key: METRON-1421
>                 URL: https://issues.apache.org/jira/browse/METRON-1421
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
> Create an implementation of the MetaAlertDao for Solr. This will involve 
> implementing the various MetaAlertDao methods using the SolrJ library and 
> also providing a SolrMetaAlertIntegrationTest (similar to 
> ElasticsearchMetaAlertIntegrationTest).

This message was sent by Atlassian JIRA

Reply via email to