[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434837#comment-16434837
]
ASF GitHub Bot commented on METRON-1421:
----------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/970
@nickwallen Refactoring should be done, barring any additional changes.
The only abstract class ends up being the UpdateDao (unless we want to be
consistent), because mutation is really the main shared code. Otherwise I just
chose to leave them.
I'm letting Travis take care of the running the existing tests for me
(although I've run the obviously relevant tests locally).
I'll run through and see what other tests should be added tomorrow (and let
me know if you come across any during review).
> Create a SolrMetaAlertDao
> -------------------------
>
> Key: METRON-1421
> URL: https://issues.apache.org/jira/browse/METRON-1421
> Project: Metron
> Issue Type: Sub-task
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve
> implementing the various MetaAlertDao methods using the SolrJ library and
> also providing a SolrMetaAlertIntegrationTest (similar to
> ElasticsearchMetaAlertIntegrationTest).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
