[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436141#comment-16436141 ]
ASF GitHub Bot commented on METRON-1421: ---------------------------------------- Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/970#discussion_r181186288 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java --- @@ -238,19 +204,19 @@ protected SearchResponse buildSearchResponse( return searchResponse; } - protected SearchResult getSearchResult(SolrDocument solrDocument, Optional<List<String>> fields) { - SearchResult searchResult = new SearchResult(); - searchResult.setId((String) solrDocument.getFieldValue(Constants.GUID)); - Map<String, Object> source; - if (fields.isPresent()) { - source = new HashMap<>(); - fields.get().forEach(field -> source.put(field, solrDocument.getFieldValue(field))); - } else { - source = solrDocument.getFieldValueMap(); - } - searchResult.setSource(source); - return searchResult; - } +// protected SearchResult getSearchResult(SolrDocument solrDocument, Optional<List<String>> fields) { --- End diff -- Deleted 1 commented line, added 13 more? Haha. > Create a SolrMetaAlertDao > ------------------------- > > Key: METRON-1421 > URL: https://issues.apache.org/jira/browse/METRON-1421 > Project: Metron > Issue Type: Sub-task > Reporter: Justin Leet > Assignee: Justin Leet > Priority: Major > > Create an implementation of the MetaAlertDao for Solr. This will involve > implementing the various MetaAlertDao methods using the SolrJ library and > also providing a SolrMetaAlertIntegrationTest (similar to > ElasticsearchMetaAlertIntegrationTest). -- This message was sent by Atlassian JIRA (v7.6.3#76005)